New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete method setattr in class Intent #5

Open

EmaBord opened this issue Jan 3, 2019 · 3 comments

EmaBord commented Jan 3, 2019

Delete method: https://github.com/ripio/marmopy-sdk/blob/2e678d651ffe80dafaf0c721a0357e2537846fe7/marmopy/Intent.py#L25

and implement method for get data y replace here : https://github.com/ripio/marmopy-sdk/blob/2e678d651ffe80dafaf0c721a0357e2537846fe7/marmopy/Intent.py#L57

Collaborator

majd1239 commented Jan 3, 2019

the setattr method contains logic that automatically recalculates the Intent ID upon a change of an instance variable

Author

EmaBord commented Jan 3, 2019

Okay, then you should just go that logic

Author

EmaBord commented Jan 3, 2019

the logic could be in the method "sign"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment