Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage to 95% #158

Open
GrayFlash opened this issue Jul 11, 2022 · 0 comments
Open

Increase code coverage to 95% #158

GrayFlash opened this issue Jul 11, 2022 · 0 comments
Labels
good first issue Good for newcomers refactor updates codebase without any feature addition or bug fixes

Comments

@GrayFlash
Copy link
Member

Is your feature request related to a problem? Please describe.
We could aim for higher code coverage of 95% for the compass.

Describe the solution you'd like
To achieve it we need to work on hitting all the statements where the error is being caught, and it should help us understand and debug our code in case an unexpected behavior is noticed.

Additional context

  • core package (overall coverage - 94.75%):
    • core/asset/patch.go - 89.8%
    • core/star - no test files
    • core/tag - few test cases where error handling can be hit.
    • core/user - mostly seems good, opts can be checked in service.go file for func NewService()
    • core/validator - 3 error conditions can be hit
  • internal package (overall coverage 84.41%):
    • internal/client - no test files for client.go
    • internal/server/health - 100% coverage
    • internal/server/v1beta1 - 84.33%
    • internal/store/elasticsearch - discovery_repository, discovery_search_repository and es.go files need more coverage on error handling.
    • internal/store/postgres - more coverage for error handling
  • pkg package (overall coverage 87.88%):
    • pkg/statsd - has no test files.
@GrayFlash GrayFlash added good first issue Good for newcomers refactor updates codebase without any feature addition or bug fixes labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor updates codebase without any feature addition or bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant