Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region merge turns NaNs to zeros #31

Open
IanHeywood opened this issue Oct 3, 2023 · 4 comments
Open

Region merge turns NaNs to zeros #31

IanHeywood opened this issue Oct 3, 2023 · 4 comments
Assignees
@Athanaseus

Comments

@IanHeywood
Copy link
Collaborator

IanHeywood commented Oct 3, 2023 •
edited
Loading

Merging a region turns NaNs in the input mask into zeros ones in the output mask.

Screenshot 2023-10-03 at 14 30 09
@o-smirnov
Copy link
Contributor

Is there a reason to keep NaNs in the mask?

@o-smirnov
Copy link
Contributor

Ah wait, turns into ones, that's no good. I could understand turning NaNs into zeroes...

@IanHeywood
Copy link
Collaborator Author

Yeah sorry I thought I'd edited the title.

@Athanaseus
Copy link
Member

Hi @IanHeywood, good catch; thanks for opening the issue.
Please try this branch for a fix: fix-issue-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Athanaseus Athanaseus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

fix-issue-31 ratt-ru/breizorro
3 participants
@o-smirnov @IanHeywood @Athanaseus