Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either a blank window or no window opens when performing actions with latest vscode #24

Open
ratmice opened this issue Aug 17, 2022 · 1 comment

Comments

@ratmice
Copy link
Owner

ratmice commented Aug 17, 2022

With the latest update to vscode, it seems as though all of the commands, which open new windows,
The break between svgDocumentCommand and showServerDocumentCommand is different,

svgDocument's still open a window, the expected contents never appear.
I believe nothing has changed in nimbleparse_lsp since the last time this worked, besides updating vscode.
So it is quite possible to be in the javascript code.

@ratmice
Copy link
Owner Author

ratmice commented Aug 20, 2022

Can't seem to reproduce this any more. 🤷

Ahh, this behavior is project specific, it is due to the handling of conflicts, should lift the conflicts: bool out of the function,
and still call stuff.replace((lexerdef, grm, sgraph, stable));, then check the conflicts flag in various places instead of relying upon the parser, etc being None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant