[2.x] Rename primary to neutral & accent to primary #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royduin
requested review from
JimmyHoenderdaal,
jordythevulder and
Roene-JustBetter
JimmyHoenderdaal
approved these changes
May 14, 2024
Roene-JustBetter
requested changes
May 14, 2024
Roene-JustBetter
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Looks good for me but I want to discuss this with @jordythevulder as well.
JimmyHoenderdaal
approved these changes
Sep 5, 2024
jordythevulder
approved these changes
Sep 5, 2024
|
Conflicts 😇 |
|
Waiting on this for now as it's a pretty annoyingly breaking change to just put out, better to just bundle this with the 3.x update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#88
Given that this is already the case in Confira, might as well waste no time and do it here.
Done with a search&replace. Given that there were already 2 occurrences of the previously undefined
ct-neutralI hope this doesn't change anyprimaryusages that should stayprimary...