Fix ntp_nak_to_the_future #19749
Merged
Fix ntp_nak_to_the_future #19749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroSteiner
force-pushed
the
fix/mod/ntp_nak_to_the_future
branch
from
f48e4a0 to
092ca5d
Compare
It is no longer in use by any modules. It has been superseded by NTPHeader.
zeroSteiner
force-pushed
the
fix/mod/ntp_nak_to_the_future
branch
from
092ca5d to
5385b3d
Compare
jheysel-r7
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks for the fix @zeroSteiner! Everything looks good to me. Ran into a small issue setting up the target but have left suggestion fix. Let me know what you think.
Testing
msf6 > use ntp_nak_to_the_future
Matching Modules
================
# Name Disclosure Date Rank Check Description
- ---- --------------- ---- ----- -----------
0 auxiliary/scanner/ntp/ntp_nak_to_the_future . normal No NTP "NAK to the Future"
Interact with a module by name or index. For example info 0, use 0 or use auxiliary/scanner/ntp/ntp_nak_to_the_future
[*] Using auxiliary/scanner/ntp/ntp_nak_to_the_future
msf6 auxiliary(scanner/ntp/ntp_nak_to_the_future) > set rhosts 127.0.0.1
rhosts => 127.0.0.1
msf6 auxiliary(scanner/ntp/ntp_nak_to_the_future) > set rport 123
rport => 123
msf6 auxiliary(scanner/ntp/ntp_nak_to_the_future) > run
[+] 127.0.0.1:123 - NTP - VULNERABLE: Accepted a NTP symmetric active association
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed
documentation/modules/auxiliary/scanner/ntp/ntp_nak_to_the_future.rb.md
Outdated
Show resolved
Hide resolved
zeroSteiner
force-pushed
the
fix/mod/ntp_nak_to_the_future
branch
from
5385b3d to
e5e0657
Compare
jheysel-r7
approved these changes
Jan 7, 2025
Release NotesThere was an issue with the ntp_nak_to_the_future module which was caused by when the BinData::Record instance was sent with the socket, the string representation of it was used instead of the packed binary. It should have been calling #to_binar_s. This fixes the issue with the auxiliary/scanner/ntp/ntp_nak_to_the_future module and documents how the module can be tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
auxiliary/scanner/ntp/ntp_nak_to_the_futuremodule which was broken in commit 5f88971 (landed in #8185). The issue was that when theBinData::Recordinstance is sent with the socket, the string representation of it was used instead of the packed binary. It should be calling#to_binar_s. This PR fixes the issue and documents how the module can be tested.This was the only module that used the
NTPSymmetricdefinition and it's been converted to instead use the newNTPHeaderdefinition which adds more natural handing forNTPTimestampandNTPShortfields. TheNTPHeaderdefinition was originally written for #19748 and these two PRs share common commits in their history for the new definition.Other NTP modules could be broken and have not been tested. NTPSymmetric had the most overlap with the definition needed for timeroast, so that was the only one that was thoroughly reviewed.
Verification
docker build -t ntpd:4.2.8p3 .docker run --rm -it --name ntp-server -p 123:123/udp ntpd:4.2.8p3msfconsoleand use the moduleRHOSTSvalue as necessaryDemo