add arch and platform detection for mssql sessions #19112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgoldman-r7
force-pushed
the
mssql-arch-platform-detection
branch
from
1f1b46f to
ff56e6f
Compare
adfoster-r7
reviewed
Apr 18, 2024
lib/rex/proto/mssql/client.rb
Outdated
Comment on lines
81
to
82
| result[:arch] = ARCH_X86_64 | ||
| result[:platform] = server_vars[:rows][0][0].match?('Windows') ? Msf::Platform::Windows.realname : Msf::Platform::Linux.realname |
There was a problem hiding this comment.
It'd be good to follow the pattern of the other PRs (postgres+mysql), as well as adding tests (following the pattern of the postgres PR) 👍
zgoldman-r7
force-pushed
the
mssql-arch-platform-detection
branch
from
ff56e6f to
777a065
Compare
adfoster-r7
reviewed
Apr 19, 2024
lib/rex/proto/mssql/client.rb
Outdated
| elsif os_data.match?('win') | ||
| platform = Msf::Platform::Windows | ||
| else | ||
| platform = Msf::Platform::Unknown |
There was a problem hiding this comment.
I think instead of unknown we'll just default to the string that the server gives back. We'll need to update the mysql logic here for consistency
adfoster-r7
reviewed
Apr 19, 2024
lib/rex/proto/mssql/client.rb
Outdated
| elsif arch_data.match?('32-bit') | ||
| arch = ARCH_X86 | ||
| else | ||
| arch = '' |
There was a problem hiding this comment.
I think instead of unknown we'll just default to the string that the server gives back. We'll need to update the mysql logic here for consistency
zgoldman-r7
force-pushed
the
mssql-arch-platform-detection
branch
from
777a065 to
8eb5f45
Compare
zgoldman-r7
force-pushed
the
mssql-arch-platform-detection
branch
from
8eb5f45 to
5c89b6a
Compare
zgoldman-r7
force-pushed
the
mssql-arch-platform-detection
branch
from
70a6624 to
0c6af95
Compare
|
Tested against Before
After
|
cgranleese-r7
approved these changes
Apr 19, 2024
Release NotesAdds architecture and platform detection for MSSQL sessions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds platform and arch detection to MSSQL
To test:
mssql_loginmodule withcreatesession=truesessionscommandBefore:
After:
