Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix map panel not saving correctly in slideshows #296

Merged
merged 1 commit into from
May 13, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented May 8, 2024

Related Item(s)

#291

Changes

  • This PR enables saving for map panels if they're being created in the slideshow editor.
  • The ability to change the type of the left side was accidentally removed in a previous PR. I've re-enabled it now.

Testing

Steps:

  1. Open the demo page.
  2. Create a new slideshow panel and add a map entry.
  3. Make some changes to the map and click Save changes at the bottom to add it to the slideshow. The unsaved changes warning should now appear.
  4. Save the entire product and ensure the map changes persist.

This change is Reviewable

Copy link

github-actions bot commented May 8, 2024

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-291/#/en/editor

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit 23a1598 into ramp4-pcar4:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants