Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant schema file and ensure editor specific flags are removed on save #491

Open
szczz opened this issue Dec 18, 2024 · 0 comments
Labels
Priority: High This task is high priority and should be tackled soon Refactor A refactor related to restructuring codebase

Comments

@szczz
Copy link
Member

szczz commented Dec 18, 2024

Description

Discussed in the 12-17 Platform meeting

We have begun adding editor specific flags to the schema which is leading to a mismatch with the storylines project. The intention was that we would use the schema from storylines and sync our copy whenever changes were made.

@yileifeng has created a discussion that further describes the issue.

We need to update RESPECT with the following changes

  1. Remove StorylinesSchema.json file in the editor codebase (verify it is unused)
  2. Ensure any editor specific flags (modified and other temporary panel editor properties) are not included in the config when saved (check the saveChanges function of each panel component)

Related issues

#490

@szczz szczz added Priority: High This task is high priority and should be tackled soon Refactor A refactor related to restructuring codebase labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High This task is high priority and should be tackled soon Refactor A refactor related to restructuring codebase
Projects
None yet
Development

No branches or pull requests

1 participant