Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new product can override an existing one #445

Open
RyanCoulsonCA opened this issue Nov 28, 2024 · 4 comments
Open

Creating a new product can override an existing one #445

RyanCoulsonCA opened this issue Nov 28, 2024 · 4 comments
Labels
Bug Something isn't working

Comments

@RyanCoulsonCA
Copy link
Member

Description

The app is currently allowing you to create a product with the UUID of an already existing product. An error used to pop up when attempting this.

Should we even be showing products that already exist when trying to create a new product? Maybe we should disable this.

Environment

  • Browser (if applicable): Chrome

Screenshots

goodbyeold

Steps to reproduce

  1. Click on Create New Storylines Product
  2. Enter the UUID of a product that already exists.
  3. Notice that no error shows up, and it appears that if I click the Save button my previous product will be overwritten.

Expected behavior

An error should appear if trying to use a UUID that is already in use.

@RyanCoulsonCA RyanCoulsonCA added Bug Something isn't working Priority: Urgent This task should be grabbed before any others labels Nov 28, 2024
@spencerwahl
Copy link
Member

I get a warning when trying to overwrite my test storyline, but I kept the autogenerated UUID. Might be an issue with custom identifiers?

@szczz
Copy link
Member

szczz commented Nov 28, 2024

I believe we originally decided to allow the overwriting of storylines. UAT currently has this message when you attempt to do this

image

I think we might want to introduce the ability to delete storylines and free up UUIDs from an admin panel. For now I agree that its probably best to prevent this. I'll bring this up at the next platform meeting.

@RyanCoulsonCA
Copy link
Member Author

RyanCoulsonCA commented Nov 28, 2024

Maybe we should allow a product owner to overwrite their own products? Seems like at the moment I can overwrite any product. Either way we should probably display a warning of some sort.

@szczz szczz added Meeting Topic topic for future meeting and removed Priority: Urgent This task should be grabbed before any others labels Nov 29, 2024
@szczz szczz removed the Meeting Topic topic for future meeting label Dec 17, 2024
@szczz
Copy link
Member

szczz commented Dec 17, 2024

Remove the ability to overwrite a storyline. If a UUID already exists, the user cannot create a new storyline with that UUID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants