Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding <style> to text editor markdown affects page UI #423

Closed
gordlin opened this issue Nov 18, 2024 · 1 comment
Closed

Adding <style> to text editor markdown affects page UI #423

gordlin opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
Bug Something isn't working Priority: Low This task can is low priority and can wait if high priority tasks exist Text/Markdown Issues concerning markdown editing, text, or embedded HTML support

Comments

@gordlin
Copy link
Member

gordlin commented Nov 18, 2024

Description

Adding a <style> element inside the text editor will affect the CSS of the storylines editor page.

Screenshots

image

Steps to reproduce

  1. Go to 00000000-0000-0000-0000-000000000000
  2. In any text editor, paste the following:
<style>
body {
    font-size: 48px;
}
</style>
  1. Witness the font size for the storylines editor increase to 48px.

Expected behavior

UI font size should not change.

Actual behavior

UI font size changes. User may get jumpscared.

@gordlin gordlin added Bug Something isn't working Priority: Low This task can is low priority and can wait if high priority tasks exist Text/Markdown Issues concerning markdown editing, text, or embedded HTML support labels Nov 18, 2024
@IshavSohal IshavSohal self-assigned this Nov 22, 2024
@yileifeng
Copy link
Member

This one might need to marinate from Spencer's comment #429 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: Low This task can is low priority and can wait if high priority tasks exist Text/Markdown Issues concerning markdown editing, text, or embedded HTML support
Projects
None yet
Development

No branches or pull requests

4 participants