Ghost images in zip container

[dan-bowerman]

Found by Matt in 2024-06-18 Testing Party

Adding an image and then changing to another slide before saving results in the image being lost. The name of the image will persist in the zip though. Likely part of the issue clients have been reporting on UAT.

[RyanCoulsonCA]

Adding an image and then changing to another slide before saving results in the image being lost.

This should be fixed after #356 is merged, but we should leave this issue open until we confirm this is the case.

If a user uploads an image and then saves the product, the image will persist on the server even if it's been removed from the product because we don't have any garbage collection in place on the server side to remove unused files. We've solved this in the past but ran into some issues so we reverted it (see #159).

[RyanCoulsonCA]

The removed garbage collection code can be found here: https://github.com/ramp4-pcar4/storylines-editor/pull/165/files#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79