Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language on Current / Historic #18

Open
james-rae opened this issue Jul 10, 2024 · 2 comments
Open

Language on Current / Historic #18

james-rae opened this issue Jul 10, 2024 · 2 comments
Labels
in DevOps This issue has been migrated to DevOps URGENT This needs to be addressed ASAP and before release

Comments

@james-rae
Copy link
Member

Describe the bug

In French, the button starts as [FR] Historic.
Toggling it, it becomes Current, which I'm assuming is the English string.
Toggling again, it becomes Historic, which is certainly the English string.
@JahidAhmed
Copy link
Member

Waiting on translations for all things timeslider related, so this will be resolved after we have all those!

@james-rae james-rae mentioned this issue Jul 10, 2024
Open
@james-rae
Copy link
Member Author

Waiting on translations for all things timeslider related, so this will be resolved after we have all those!

All good, but make sure the second half doesn't keep happening. Looks like it's reverting to English instead of the [FR] placeholders.

@dan-bowerman dan-bowerman added the URGENT This needs to be addressed ASAP and before release label Jul 10, 2024
@JahidAhmed JahidAhmed added the in DevOps This issue has been migrated to DevOps label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in DevOps This issue has been migrated to DevOps URGENT This needs to be addressed ASAP and before release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dan-bowerman @james-rae @JahidAhmed