Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is an exception thrown for dates < 1970? #6

Open
darrendahl opened this issue Feb 13, 2017 · 2 comments
Open

Why is an exception thrown for dates < 1970? #6

darrendahl opened this issue Feb 13, 2017 · 2 comments

Comments

@darrendahl
Copy link

I understand the timestamps for pre epoch (Jan 1, 1970) dates are negative numbers, but I believe there should still be a way to handle these dates. What is the reason you chose to limit dates to be only >= 1970?

@ramalho
Copy link
Owner

ramalho commented Mar 22, 2017

@darrendahl Please send a pull request with the changes you propose to support dates farther back. Besides the actual implementation, the pull request should specify what is the earliest date supported and include tests and error checking enforcing the valid date ranges.

@rantrix
Copy link

rantrix commented Jun 3, 2017

This might be helpful for you @darrendahl since it doesn't look like a PR is going to be made any time soon haha.

I recently created a similar project that generates a calendar given a month and a year or a date. Maybe it'll help solve your use case for such a library? https://github.com/rantrix/calendator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants