Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rochester corrections files #21

Open
ram1123 opened this issue Oct 22, 2023 · 4 comments · Fixed by #27 · May be fixed by #60
Open

Update Rochester corrections files #21

ram1123 opened this issue Oct 22, 2023 · 4 comments · Fixed by #27 · May be fixed by #60
Labels
enhancement New feature or request HZZ_4l_Analysis

Comments

@ram1123
Copy link
Owner

ram1123 commented Oct 22, 2023

Rochester correction files are already present in the official nanoAOD-tools:

We should use these files instead of adding ours.

@YujiLee301

@ram1123 ram1123 added the enhancement New feature or request label Oct 22, 2023
@vukasinmilosevic
Copy link

This has been presented by Yuji in the last meeting.

@ram1123 ram1123 linked a pull request Nov 29, 2023 that will close this issue
@ram1123 ram1123 closed this as completed Nov 29, 2023
@ram1123 ram1123 reopened this Nov 29, 2023
@vukasinmilosevic
Copy link

The files have been validated between mini -> nano frameworks in this regard, but we still need to update to the correct Run 3 version.

@ram1123
Copy link
Owner Author

ram1123 commented May 28, 2024

For this just add the latest files in one of directory. And we need to copy them while setup to appropriate place. And if something needed to update in the nano-AODTOOLS then create a patch that one will apply while setting up the framework.

@ram1123
Copy link
Owner Author

ram1123 commented Oct 25, 2024

Update from Filippo:

Rochester correction files for Run-3 can be obtained from here: https://gitlab.cern.ch/cms-muonPOG/muonscarekit/-/tree/master/corrections?ref_type=heads

He added his git patches for this FW and nanoAOD-tools at his afs public path: /afs/cern.ch/user/f/ferrico/public/. The file names at this path are:

nanoAOD_skim_UPDATE.txt
NanoAODTools.txt
NanoAODTools_src_MuonScaRe.cc
NanoAODTools_interface_MuonScaRe.h
NanoAODTools_python_postprocessing_data_BuildFile.xml

@ram1123 ram1123 linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HZZ_4l_Analysis
Projects
None yet
2 participants