Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded pdf inside pheatmap function causes issues and unwanted behavior in a knitting context +bugfix #77

Open
chrarnold opened this issue Mar 23, 2021 · 0 comments

Comments

@chrarnold
Copy link

chrarnold commented Mar 23, 2021

I found that the hard-coded lines pdf(file = NULL) and dev.off() before and after the heatmap_motor call cause a big issue when being in a knitting + PDF context. That is, when calling pdf() before calling pheatmap, the hard-coded pdf() messes up the knitting and causes unwanted and hard to understand behavior. By removing these two lines, I was able to successfully work with pheatmap and pdf both inside and outside of Rmds.

I propose to change this and provide a fix to it soon, thank you! It seems easy to fix :)

I can provide more details if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant