Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in nested collections rendered in RTL order in the "Select collection" dialog #143

Open
chriseskow opened this issue Sep 6, 2024 · 0 comments

Comments

@chriseskow
Copy link

Describe the bug
If you have a nested collection containing special (e.g. non-alphanumeric) characters at the end of the collection name, those characters will be reversed and moved to the beginning of the full collection path when you navigate to that collection in the "Select collection" dialog box.

This also appears to cause special characters at the beginning of the top-most collection to be moved to the end of the full path, again in reverse order.

A good real world example would be the the collection path Dev / Languages / C++. In the Select Collection dialog, this path appears as ++Dev / Languages / C:

Screenshot 2024-09-06 at 3 23 41 PM

This appears to be caused by direction: rtl CSS property in src/co/collections/item/title.module.styl. I'm not sure why that property is set, but removing it in the browser dev tools appears to fix the issue.

To Reproduce
Steps to reproduce the behavior:

  1. Create two collections !@foo and bar#$, the second nested within the first as per the screenshot below.
  2. Select a bookmark, and click the collection dropdown to open the "Select collection" dialog.
  3. Navigate to or search for the new bar#$ collection.
  4. Note that the special characters are reversed, as in the screenshot below.

Expected behavior
The collection path should appear as !@foo / bar#$.

Screenshots

Collections with special characters:
Screenshot 2024-09-06 at 3 49 57 PM

How they appear in "Select collection":
Screenshot 2024-09-06 at 3 49 50 PM

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox
  • Version: 130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant