Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use V2 ABI in the settlement function #1129

Closed
pirapira opened this issue Jul 18, 2019 · 1 comment · Fixed by #1392
Closed

Use V2 ABI in the settlement function #1129

pirapira opened this issue Jul 18, 2019 · 1 comment · Fixed by #1392
Assignees
@karlb
Labels
efforts: a few hours hack P1 urgent, blocker, or makes life easier forever

Comments

@pirapira
Copy link
Contributor

pirapira commented Jul 18, 2019 •
edited
Loading

We need four new arguments in the settlement function

This issue keeps track of using V2 ABI of Solidity so the stack depth constraint can be releaved.
@pirapira pirapira added P1 urgent, blocker, or makes life easier forever efforts: a few hours hack labels Jul 18, 2019
@pirapira pirapira mentioned this issue Jul 22, 2019
Open
@Dominik1999
Copy link

Dominik1999 commented May 28, 2020 •
edited
Loading

does not include the Raiden side

@karlb karlb self-assigned this May 29, 2020
karlb added a commit to karlb/raiden-contracts that referenced this issue Jun 2, 2020
@karlb
Use ABI V2 to shorten settle arg list
adbcbde 
This allows us to add additional arguments for hash salts and signatures
that allow settling on behalf of other users.

I kept compatibility with the existing signature and introduced a new
settle function using structs. Is this a good idea? Also a better name
than `settleChannel2` would be nice.

Closes raiden-network#1129
@karlb karlb mentioned this issue Jun 2, 2020
Merged
konradkonrad pushed a commit that referenced this issue Jun 9, 2020
@karlb @konradkonrad
Use ABI V2 to shorten settle arg list
f989d78 
This allows us to add additional arguments for hash salts and signatures
that allow settling on behalf of other users.

I kept compatibility with the existing signature and introduced a new
settle function using structs. Is this a good idea? Also a better name
than `settleChannel2` would be nice.

Closes #1129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlb karlb

Labels
efforts: a few hours hack P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ABI V2 to shorten settle arg list karlb/raiden-contracts
3 participants
@pirapira @karlb @Dominik1999