Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SRTM from RasterDataSources.jl #242

Open
jenkspt opened this issue Jan 20, 2022 · 5 comments
Open

Add support for SRTM from RasterDataSources.jl #242

jenkspt opened this issue Jan 20, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@jenkspt
Copy link

jenkspt commented Jan 20, 2022

SRTM is a new dataset in RasterDataSources.jl. The SRTM type needs to be added to src/sources/rasterdatasources.jl to support the following interface:

Raster(SRTM; crs=..., bounds=(...))

Details:

  • getraster(SRTM, ...) returns a matrix of tile paths, which is currently unsupported by Raster (?)
  • Since tiles are still somewhat large (6000 x 6000 pixels), using a BlockArray of DiskArrays is an option for the Raster array backing. (BlockArrays.jl)
@jenkspt
Copy link
Author

jenkspt commented Jan 20, 2022

@rafaqz

@rafaqz
Copy link
Owner

rafaqz commented Jan 20, 2022

Yep. Could also be generally useful to have a way to stitch tiles together, mosaic is very slow compared to when you know the tiles match step size and dont overlap.

This needs 2 parts. A way to stitch the BlockArrays, and a way to combine the dimensions. Probably combine already has that part solved. Other than that its just a regular Raster.

Then we'll need a method for RasterDataSources types that have tiles, or just this SRTM to get started.

Do you want to have a go at a PR?

@jenkspt
Copy link
Author

jenkspt commented Jan 20, 2022

Yea I'll have a go at it. Thanks for the feedback!

@rafaqz
Copy link
Owner

rafaqz commented Jan 20, 2022

Sweet! Don't hesitate to ping me on things here, or make a work in progress PR. I try to streamline things but DimensionalData.jl is inherantly pretty complicated, and you may need to understand a bit of how LookupArray and Dimensions work to get this done.

@rafaqz
Copy link
Owner

rafaqz commented Aug 4, 2023

I've just registered a new version of DiskArrays.jl with lazy cat, so we can cat together the SRTM tiles without reading the files.

@rafaqz rafaqz added the enhancement New feature or request label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants