Skip to content

Latest commit

 

History

History
56 lines (38 loc) · 2.29 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

56 lines (38 loc) · 2.29 KB
Raw

Please Note:

  1. PRs will be reviewed from oldest to newest
  2. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be ither closed by the team or depending on its utility will be taken over by someone on the team
  3. PRs that do not have the PR template completely filled out with all declarations satisfied will not be reviewed by the team.

Please delete the notes above after reading.

Purpose

(FILL ME IN) This section describes why this PR is here, the changes made and any functionality added/removed or refactoring work.

Current behaviour

(FILL ME IN) This section describes the current state of the codebase or behaviour of the app. Add current UI snapshots if any changes will be made.

New behaviour

(FILL ME IN) This section describes the new state of the codebase or behaviour of the app. Add new UI snapshots if any changes are be made.

Implementation

(FILL ME IN) This section describes details regarding the implementation & approach taken, particularly if changes are significant or a different approach is used.

Known limitations & dependencies

(FILL ME IN) This section describes things introduced by the PR that are :

  • limitations
  • edge cases
  • added dependencies on packages or external codebases

Declarations

Check these if you believe they are true

Codebase

  • The code base is in a better state after this PR
  • Is documented according to the standards and ready for inclusion with release notes.
  • User facing strings, if any, are extracted into *.resx files

Testing

  • The level of testing this PR includes is appropriate
  • The solution has been compiled, loaded and tested in current Dynamo version (1.3)
  • All tests pass using the self-service CI (if present).

Changes

  • Snapshot of UI changes, if any.
  • Version change follows Semantic Versioning and is updated in the assembly DLL version.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR by @mention)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of, using @mention