Update autorest version for Radius #8042

lakshmimsft · 2024-11-09T03:25:04Z

Description

Updating autorest version for Radius.
@autorest/core v3.10.3
@autorest/go v4.0.0-preview.69

@autorest/cli is currently at 3.7.1. No updates needed, current code uses v3.7.1.

Notes: All clients generated will be included in this PR except for GenericResource (pkg/cli/clients_new/generated/)which needs some discussion with the team.

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

codecov · 2024-11-09T03:46:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.94%. Comparing base (9e41b41) to head (5a5193f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8042   +/-   ##
=======================================
  Coverage   58.94%   58.94%           
=======================================
  Files         567      567           
  Lines       37726    37726           
=======================================
  Hits        22236    22236           
  Misses      13945    13945           
  Partials     1545     1545

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-11-09T04:56:47Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`6bd877b`
Unique ID	func8e3355755d
Image tag	pr-func8e3355755d

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8e3355755d
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8e3355755d
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func8e3355755d
controller test image location: ghcr.io/radius-project/dev/controller:pr-func8e3355755d
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8e3355755d
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-11-11T18:22:11Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`5a5193f`
Unique ID	func393552cb99
Image tag	pr-func393552cb99

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func393552cb99
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func393552cb99
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func393552cb99
controller test image location: ghcr.io/radius-project/dev/controller:pr-func393552cb99
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func393552cb99
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin · 2024-11-11T22:51:26Z

build/generate.mk

@@ -79,27 +79,27 @@ generate-genericcliclient: generate-node-installed generate-autorest-installed
 .PHONY: generate-rad-corerp-client
 generate-rad-corerp-client: generate-node-installed generate-autorest-installed generate-tsp-installed generate-openapi-spec ## Generates the corerp client SDK (Autorest).
 	@echo "$(AUTOREST_MODULE_VERSION) is module version"
-	autorest pkg/corerp/api/README.md --tag=core-2023-10-01-preview
+	autorest pkg/corerp/api/README.md --tag=core-2023-10-01-preview && rm pkg/corerp/api/v20231001preview/go.mod


What is the go.mod that we are removing?

We're required to set values for module and module version because we set azure-arm: true in autorest configuration. This creates a go.mod file. It looks for existing go.mod in the output directory and creates it since it doesn't already exist. We can remove it post generation of file, in our usecase, since we want the generated output to be part of the existing module at the root of the project.

how were we removing it before?

kachawla · 2024-11-27T01:45:45Z

pkg/corerp/api/v20231001preview/fake/zz_generated_applications_server.go

do you know what's causing this fake directory to be created?

kachawla · 2024-11-27T02:19:13Z

pkg/daprrp/api/README.md

@@ -44,7 +44,8 @@ The following configuration generates track2 go models and client.

 ```yaml $(tag) != ''
 version: 3.*.*
-use: "@autorest/[email protected]"
+use: "@autorest/[email protected]"
+module: "github.com/radius-project/radius/pkg/daprrp/api/v20231001preview"
 module-version: 0.0.1


does this need to be updated as well?

kachawla · 2024-11-27T02:27:21Z

pkg/corerp/api/README.md

@@ -46,7 +46,8 @@ The following configuration generates track2 go models and client.

 ```yaml $(tag) != ''
 version: 3.*.*
-use: "@autorest/[email protected]"
+use: "@autorest/[email protected]"
+module: "github.com/radius-project/radius/pkg/corerp/api/v20231001preview"


was module made a required property in the new version?

kachawla · 2024-11-27T02:29:15Z

pkg/corerp/api/v20231001preview/zz_generated_constants.go

 	ProvisioningStateCanceled ProvisioningState = "Canceled"
-	// ProvisioningStateCreating - The resource is being created
+// ProvisioningStateCreating - The resource is being created


Comments formatting seems off..

pending questions - approved by mistake

Signed-off-by: lakshmimsft <[email protected]>

lakshmimsft requested review from a team as code owners November 9, 2024 03:25

lakshmimsft temporarily deployed to publish-bicep November 9, 2024 03:25 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep November 9, 2024 03:35 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/autorestupdate branch from d90069b to 6bd877b Compare November 9, 2024 04:45

lakshmimsft temporarily deployed to publish-bicep November 9, 2024 04:45 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests November 9, 2024 04:55 — with GitHub Actions Inactive

lakshmimsft marked this pull request as draft November 10, 2024 05:00

lakshmimsft force-pushed the lakshmimsft/autorestupdate branch from 6bd877b to 4f33be7 Compare November 10, 2024 06:41

lakshmimsft temporarily deployed to publish-bicep November 10, 2024 06:42 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep November 11, 2024 18:07 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/autorestupdate branch from b0af588 to 5a5193f Compare November 11, 2024 18:17

lakshmimsft temporarily deployed to publish-bicep November 11, 2024 18:18 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests November 11, 2024 18:21 — with GitHub Actions Inactive

lakshmimsft changed the title ~~<WIP-DO NOT REVIEW> Update autorest version for Radius~~ Update autorest version for Radius Nov 11, 2024

lakshmimsft marked this pull request as ready for review November 11, 2024 19:05

ytimocin reviewed Nov 11, 2024

View reviewed changes

kachawla previously approved these changes Nov 27, 2024

View reviewed changes

lakshmimsft force-pushed the lakshmimsft/autorestupdate branch from 5a5193f to 1567ac9 Compare November 27, 2024 21:35

lakshmimsft temporarily deployed to publish-bicep November 27, 2024 21:35 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/autorestupdate branch from 1567ac9 to dcbf17a Compare November 27, 2024 22:20

lakshmimsft temporarily deployed to publish-bicep November 27, 2024 22:21 — with GitHub Actions Inactive

lakshmimsft added 4 commits November 27, 2024 14:30

updated to autorest latest version

37f67cd

intermidiate checkin

90bc905

build/make generate successful

61558c1

update routes

770bf80

lakshmimsft added 4 commits November 27, 2024 14:30

updating datastoresrp

89dd076

format tsp

87b6200

add corerp

191d733

generate clients for ucp, dapr

64a21cd

lakshmimsft force-pushed the lakshmimsft/autorestupdate branch from dcbf17a to 7349271 Compare November 27, 2024 22:31

lakshmimsft temporarily deployed to publish-bicep November 27, 2024 22:31 — with GitHub Actions Inactive

upd client for messengerrp

7625b4f

Signed-off-by: lakshmimsft <[email protected]>

lakshmimsft force-pushed the lakshmimsft/autorestupdate branch from 7349271 to 7625b4f Compare November 27, 2024 22:33

lakshmimsft deployed to publish-bicep November 27, 2024 22:33 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update autorest version for Radius #8042

Update autorest version for Radius #8042

lakshmimsft commented Nov 9, 2024 •

edited

Loading

codecov bot commented Nov 9, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 9, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading

ytimocin Nov 11, 2024

lakshmimsft Nov 12, 2024

kachawla Nov 27, 2024

kachawla Nov 27, 2024

kachawla Nov 27, 2024

kachawla Nov 27, 2024

kachawla Nov 27, 2024

Update autorest version for Radius #8042

Are you sure you want to change the base?

Update autorest version for Radius #8042

Conversation

lakshmimsft commented Nov 9, 2024 • edited Loading

Description

Contributor checklist

codecov bot commented Nov 9, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Nov 9, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 11, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin Nov 11, 2024

Choose a reason for hiding this comment

lakshmimsft Nov 12, 2024

Choose a reason for hiding this comment

kachawla Nov 27, 2024

Choose a reason for hiding this comment

kachawla Nov 27, 2024

Choose a reason for hiding this comment

kachawla Nov 27, 2024

Choose a reason for hiding this comment

kachawla Nov 27, 2024

Choose a reason for hiding this comment

kachawla Nov 27, 2024

Choose a reason for hiding this comment

lakshmimsft commented Nov 9, 2024 •

edited

Loading

codecov bot commented Nov 9, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 9, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 11, 2024 •

edited

Loading