Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove environment flag from graph #8099

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove environment flag from graph #8099

wants to merge 2 commits into from

Conversation

gpltaylor
Copy link
Contributor

Description

As the environment flag has no impact on app graph the best option is to remove.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #7507

@gpltaylor
Remove environment flag from graph
1fd09c4 
fixes: radius-project#7507

As the enviroment has no impact on `app graph` the best option is to remove.

Signed-off-by: Garry Taylor <[email protected]>
@gpltaylor gpltaylor requested review from a team as code owners November 27, 2024 12:53
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 27, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository gpltaylor/radius
Commit ref 1fd09c4
Unique ID funcde1d367730
Image tag pr-funcde1d367730
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcde1d367730
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcde1d367730
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcde1d367730
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcde1d367730
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcde1d367730
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

@ytimocin ytimocin deployed to functional-tests November 27, 2024 18:21 — with GitHub Actions Active
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 27, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository gpltaylor/radius
Commit ref 044d07c
Unique ID funccb8da96363
Image tag pr-funccb8da96363
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funccb8da96363
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funccb8da96363
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funccb8da96363
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funccb8da96363
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funccb8da96363
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@gpltaylor
Copy link
Contributor Author

@ytimocin is this OK to merge? Let me know if you need anything changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytimocin ytimocin ytimocin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rad app graph allows a -e flag which takes no effect
2 participants
@gpltaylor @ytimocin