Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete for wxf #4872

Closed
wants to merge 1 commit into from
Closed

Add autocomplete for wxf #4872

wants to merge 1 commit into from

Conversation

Svenito
Copy link
Contributor

@Svenito Svenito commented May 12, 2016

for #4751

@ret2libc
Copy link
Contributor

Probably I'm not understand what you want to achieve with this patch :( why would you want to autocomplete the configuration variables when you use w and wx? Could you provide here an example of the use case of this patch?

@Svenito
Copy link
Contributor Author

Svenito commented May 12, 2016

Maybe I misunderstood then or edited the wrong file. Latter most likely. Trying to add wxf to the list of commands when typing w<tab>. Still figuring out lots on radare

@ret2libc
Copy link
Contributor

Ok don't worry :) If you just want to add 'wxf' to the list of commands that are autocompleted, the first line of your patch is enough. The rest should be to autocomplete the arguments of a command. Seems like you copied the autocompletion of the e command, that is indeed used to change the variables. Not needed though in this case

@@ -446,7 +446,7 @@ static const char *radare_argv[] = {
"b", "bf", "b?",
"/", "//", "/a", "/c", "/m", "/x", "/v", "/v2", "/v4", "/v8", "/r"
"y", "yy", "y?",
"wx", "ww", "w?",
"wx", "ww", "w?", "wxf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line

@Svenito
Copy link
Contributor Author

Svenito commented May 12, 2016

Ok thanks. I tried just the first line and had no luck. Might have been something else though. I'll double check tomorrow.

@ret2libc
Copy link
Contributor

Oh that's weird. I tried that to and when i pressed "w" i could see "wxf" on the list of possible completions :(

@Svenito
Copy link
Contributor Author

Svenito commented May 13, 2016

I must have goofed somewhere. Remove the config var block and squashed commits

@ret2libc
Copy link
Contributor

Thanks a lot!

@ret2libc ret2libc closed this May 13, 2016
@Svenito Svenito deleted the wfx-autocomp branch May 13, 2016 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants