Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding Debug button to #lang languages #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikesperber
Copy link
Member

@mikesperber mikesperber changed the title Add Debug button to #lang htdp/asl. Allow adding Debug button to #lang languages Oct 11, 2022
@soegaard
Copy link
Member

@rfindler This PR seems to be forgotten?

@rfindler
Copy link
Member

rfindler commented Mar 4, 2024

Thank you for the reminder @soegaard ! I did somehow miss this one.

@mikesperber I think that maybe changing something around here based on these docs is a better way to go. Does that not work?

@mikesperber
Copy link
Member Author

@mikesperber I think that maybe changing something around here based on these docs is a better way to go. Does that not work?

Yes: But that has this as a prerequisite.

@rfindler
Copy link
Member

rfindler commented Sep 2, 2024

@mikesperber I think that maybe changing something around here based on these docs is a better way to go. Does that not work?

Yes: But that has this as a prerequisite.

When I change the quoted code to have these two lines:

    [(drscheme:opt-out-toolbar-buttons)
     '(macro-stepper)]

(instead of returning #f from that case), then I see a debug button and clicking on it seems to turn on the debugger.

Can you please elaborate on what you tried and how it goes wrong that led you to want to make modifications to drracket itself here?

@mikesperber
Copy link
Member Author

@rfindler Ah, you mean the bottom line of that snippet, not the top lines. (The docs you quote are almost impossible to find if you don't know about them beforehand.)

I was following the example of the syntax-check and stepper buttons - the top lines of the snippet.

Shouldn't those be done the same way?

@rfindler
Copy link
Member

rfindler commented Sep 2, 2024

@rfindler Ah, you mean the bottom line of that snippet, not the top lines.

You may need to change all the lines, I guess.

I was following the example of the syntax-check and stepper buttons - the top lines of the snippet.

Shouldn't those be done the same way?

Adding things to the code that's shared between various parts of drracket and the namespace in the interactions window should be done as infrequently as possible. When there is more shared, then it can get difficult to ensure that, for example, hitting the Run button really does reset the program that's being run.

@rfindler
Copy link
Member

I'm still seeing two "Check Syntax" buttons in the teaching languages ASL with the current commit.

Screenshot 2024-09-12 at 3 56 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No debug toolbar button for #lang htdp/asl
3 participants