Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports (thanks elp!) #11305

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

mkuratczyk
Copy link
Contributor

Result of running:

elp lint --diagnostic-filter W0020 --apply-fix --in-place --include-tests

There were two false positives, which I reverted already. Creating a draft PR to see how the tests go.

@mergify mergify bot added the bazel label May 23, 2024
@mkuratczyk mkuratczyk force-pushed the remove-unused-imports branch from 75077e4 to 85e6de1 Compare May 23, 2024 13:45
@lukebakken
Copy link
Collaborator

This seems like a great change to add to .git-blame-ignore-revs

https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

@mkuratczyk mkuratczyk force-pushed the remove-unused-imports branch from 85e6de1 to ca53195 Compare May 23, 2024 14:39
@mkuratczyk mkuratczyk marked this pull request as ready for review May 23, 2024 15:37
@michaelklishin
Copy link
Member

I assume that this kind of changes better applied to v3.13.x independently, that is, not as a backport.

@michaelklishin michaelklishin merged commit 38a6012 into main May 23, 2024
20 checks passed
@michaelklishin michaelklishin deleted the remove-unused-imports branch May 23, 2024 21:00
@michaelklishin michaelklishin added this to the 4.0.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants