qucs-s windows uses old icon mac uses new one

[dsm]

Hi, this is the difference mac and windows icon and qucs-s.exe normally uses different icon but innosetup changed icon to old icon but not visible in explore it's strange. We should set app icon using Qt API and CMake. I created new.ico based on qucs-s.svg in qucs/bitmaps .

[ra3xdh]

It's need to replace icons in contrib/InnoSetup/misc It still use 64x64 icons. Maybe switch to higher resolution or vector icon if supported.

[dsm]

256x256 looks good on Full HD screen i changed in innosetup locally and build exe, Qt page says convert icon to ico file, i think svg not supported.

[dsm]

ico file can store multiple resoultion icons in a single file using

magick convert 16.png 32.png 48.png 128.png 256.png -colors 256 icon.ico

[dsm]

I sent a PR #932 to fixed windows icon but app title icon not changed it needs to be changed in Qt code
App icon:

title icon:

[ra3xdh]

The window title icon is set inside QucsApp::InitView I think the existing icon should remain, but XPM should be replaced by SVG or higher resolution.

[dsm]

#ifndef __APPLE__
  setWindowIcon (QPixmap(QString(":/bitmaps/hicolor/scalable/apps/qucs.svg")));
#else

I tested this usage and succesfully render both app and title svg icon. about diolog also used 128x128 png maybe this one can be used there. Why you think the existing icon should remain (big.qucs.xpm) generally app and title icons are same.

[ra3xdh]

I tested this usage and succesfully render both app and title svg icon. about diolog also used 128x128 png maybe this one can be used there.

Yes, this one could be accepted.