-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol Text Issue #873
Comments
I believe I understand what is the cause of the problem, but I'm not so sure. When the symbol is saved its elements are saved as paintings (a line, a rect, a text, etc.) and in that case texts have their sizes measured in points (pts). But texts as parts of a symbol have to have their sizes in pixels, so when a symbol is loaded the sizes in points are treated as sizes in pixels, hence the "scaling". I'll try to come up with a fix. |
Any progress on this? The issue didn't exist in March when I did the attached project. Any symbol with text looks OK when making and editing the symbol but looks bad when the symbol is placed on a schematic. |
@tomhajjar hi! Check the linked PR please, it should fix the problem. I've added explicit conversion from points to pixels, when symbol is read by component. But there is drawback with this approach: conversion from points to pixels gives different results on different displays because different pixel density. So it's more like a workaround than a proper fix. |
Will do when the latest Windows nightly is released |
Fixed by #912. |
I checked a number of old projects and the update is a big improvement. |
The text font/size/position used in a subcircuit symbol still does not match the symbol once made into a library. The library symbol text is sub-optimal. I thought this was addressed in #765 & #777.
Compare TL494 Symbol in TL494.sch to the one in PWM_Controller.lib
TL494.zip
The text was updated successfully, but these errors were encountered: