Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol Text Issue #873

Closed
tomhajjar opened this issue Jul 27, 2024 · 6 comments · Fixed by #912
Closed

Symbol Text Issue #873

tomhajjar opened this issue Jul 27, 2024 · 6 comments · Fixed by #912
Labels
Milestone

Comments

@tomhajjar
Copy link

tomhajjar commented Jul 27, 2024

The text font/size/position used in a subcircuit symbol still does not match the symbol once made into a library. The library symbol text is sub-optimal. I thought this was addressed in #765 & #777.

Compare TL494 Symbol in TL494.sch to the one in PWM_Controller.lib

2024-07-26_201822

2024-07-26_201747

TL494.zip

@tomhajjar tomhajjar changed the title Symbol Text Issue Still Not Fixed Symbol Text Issue Jul 28, 2024
@wawuwo
Copy link
Contributor

wawuwo commented Jul 30, 2024

I believe I understand what is the cause of the problem, but I'm not so sure.

When the symbol is saved its elements are saved as paintings (a line, a rect, a text, etc.) and in that case texts have their sizes measured in points (pts). But texts as parts of a symbol have to have their sizes in pixels, so when a symbol is loaded the sizes in points are treated as sizes in pixels, hence the "scaling".

I'll try to come up with a fix.

@ra3xdh ra3xdh added the bug label Jul 30, 2024
@ra3xdh ra3xdh added this to the 24.4.0 milestone Jul 30, 2024
@tomhajjar
Copy link
Author

tomhajjar commented Aug 22, 2024

Any progress on this? The issue didn't exist in March when I did the attached project. Any symbol with text looks OK when making and editing the symbol but looks bad when the symbol is placed on a schematic.

2024-08-22_111921
2024-08-22_111857

Digital_Analog_Mixed_prj.zip

@wawuwo
Copy link
Contributor

wawuwo commented Aug 25, 2024

@tomhajjar hi! Check the linked PR please, it should fix the problem. I've added explicit conversion from points to pixels, when symbol is read by component. But there is drawback with this approach: conversion from points to pixels gives different results on different displays because different pixel density. So it's more like a workaround than a proper fix.

@tomhajjar
Copy link
Author

Will do when the latest Windows nightly is released

@ra3xdh
Copy link
Owner

ra3xdh commented Aug 25, 2024

Fixed by #912.

@tomhajjar
Copy link
Author

I checked a number of old projects and the update is a big improvement.

@ra3xdh ra3xdh modified the milestones: 24.4.0, 24.3.1 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants