Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"current" branch will not build, missing "qucslib_common.h" #171

Closed
tvrusso opened this issue Oct 7, 2022 · 2 comments
Closed

"current" branch will not build, missing "qucslib_common.h" #171

tvrusso opened this issue Oct 7, 2022 · 2 comments
Assignees
Milestone

Comments

@tvrusso
Copy link
Collaborator

tvrusso commented Oct 7, 2022

I just tried to build the code off of the current branch today and it failed. qucs/qucs.cpp includes "qucslib_common.h" but that file no longer exists in the source tree. I tried just removing the include, but there were undeclared identifiers and other issues, and other files also include qucslib_common.h.

ra3xdh added a commit that referenced this issue Oct 7, 2022
ra3xdh added a commit that referenced this issue Oct 7, 2022
@ra3xdh
Copy link
Owner

ra3xdh commented Oct 7, 2022

Hello Tom, I forgot to commit qucslib_common.h after removing the qucs-lib tool #139. I have just restored the missing file. Please try to compile again. I have recently added CMake build test on the master branch to prevent such issues in the future https://github.com/ra3xdh/qucs_s/actions/workflows/cmake.yml This will be available for all branches after merging master and current

@ra3xdh ra3xdh self-assigned this Oct 7, 2022
@ra3xdh ra3xdh added this to the 1.0.0 milestone Oct 7, 2022
@tvrusso
Copy link
Collaborator Author

tvrusso commented Oct 7, 2022

Thanks, Vadim. Yes, it is fine now.

I had just created a pull request while you were fixing it, but you beat me to the punch.

@tvrusso tvrusso closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants