Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ REQUEST ] adding Qt App style selection to settings. #1118

Closed
3 tasks done
dsm opened this issue Dec 4, 2024 · 5 comments · Fixed by #1125
Closed
3 tasks done

[ REQUEST ] adding Qt App style selection to settings. #1118

dsm opened this issue Dec 4, 2024 · 5 comments · Fixed by #1125
Assignees
Milestone

Comments

@dsm
Copy link
Collaborator

dsm commented Dec 4, 2024

Hi @ra3xdh, I am currently working on to solve this feature request. Below are the tasks to be completed.

I think we can improve svg rendering and compatability with Qt to converting all non-optimized SVG to Optimized SVG(Plain SVG) ?

Thanks.

@dsm dsm self-assigned this Dec 4, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2024

Qt to converting all non-optimized SVG to Optimized SVG(Plain SVG) ?

The SVGs used for device icons and toolbar icons were optimized using the SVGO tool https://www.drupal.org/project/svgo The other SVGs need to be checked.

refactoring some svg file to looks good on dark theme.

This may require to have two sets of images: for light and dark theme. The most of device icons are rendered automatically. It is not clear how to render the icon for the dark theme. The simple color inversion will not work. Probably you need to provide an options for wire color, device color, etc for light and dark theme. This will require to refector the components, because the colors are hardcoded now.

@dsm
Copy link
Collaborator Author

dsm commented Dec 4, 2024

some SVGs has white background some has transparent option in tools as shown below tool screenshot. I'll remove it, and adding white-background in code as workaround but yes changing color of text and wire for dark theme.

image

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2024

Yes, the images in Active filter tool are not optimized.

@dsm
Copy link
Collaborator Author

dsm commented Dec 4, 2024

#874 issue has mentioned some svg icon has white border artifact but actually svg has a border it should be remove manually.

<path d="M.5.5h127v127H.5z" fill-opacity="0" stroke="#fff" stroke-linecap="square" stroke-linejoin="round" style="paint-order:stroke fill markers"/>

image

@ra3xdh ra3xdh linked a pull request Dec 6, 2024 that will close this issue
@ra3xdh ra3xdh added this to the 25.1.0 milestone Dec 6, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Dec 6, 2024

Implemented by #1125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants