Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Frequency Analysis Status #1081

Closed
tomhajjar opened this issue Nov 21, 2024 · 8 comments · Fixed by #1093
Closed

Single Frequency Analysis Status #1081

tomhajjar opened this issue Nov 21, 2024 · 8 comments · Fixed by #1093
Labels

Comments

@tomhajjar
Copy link

tomhajjar commented Nov 21, 2024

It's been a long time since we discussed Single Frequency Analysis and I don't know the status.

I imported a newly made Qucs 0.0.20 project that was converted from QucsStudio. Qucs allow single frequency but Qucs-S grays out the menu settings. Is this normal?

2024-11-20_223641
2024-11-20_223743

Combline_Filter_qucs_prj.zip

@ra3xdh
Copy link
Owner

ra3xdh commented Nov 23, 2024

It's been a long time since we discussed Single Frequency Analysis and I don't know the status.

The single frequency sweep in SPICE is a hack. It requires vector assembling to work as expected. Otherwise you will get a set of 1x1 plots. This operation cannot be automatized. Write the script by hands if this simulation is needed.

The single frequency and list sweep should work only when Qucsator is selected.

Qucs allow single frequency but Qucs-S grays out the menu settings.

This may be a consequence of #1054 The values are not grayed out in my case, but the Apply button doesn't work if value is selected. The list works as expected. Also the list preset value has disappeared. This may be misleading for the new users, because it's need to know the list syntax. Here is the screen recording.

Screencast_20241123_090111.webm

The preset values from the old dialog:
image

@iwbnwif , Please have a look at this.

@ra3xdh ra3xdh added the bug label Nov 23, 2024
@iwbnwif
Copy link
Contributor

iwbnwif commented Nov 23, 2024

Yes, it is almost certainly a problem with the new dialog.

Tbh, I am not sure if the single 'value' option is needed. It is easy to just enter a single value in the list. At the moment, the either [100 MHz] or 100 MHz will work with the 'list' option to give the desired result.

@iwbnwif
Copy link
Contributor

iwbnwif commented Nov 24, 2024

Qucs allow single frequency but Qucs-S grays out the menu settings. Is this normal?

This is because the file has the sweep type defined as const which is not currently implemented in Qucs-S. Instead, the sweep type should be list and have a single value, either alone or surrounded by square brackets.

@iwbnwif
Copy link
Contributor

iwbnwif commented Nov 24, 2024

Also the list preset value has disappeared. This may be misleading for the new users, because it's need to know the list syntax.

I have restored the functionality whereby the start and stop values are used to create the list when the dialog is opened, or if they are changed at all. Conversely, providing the list is correctly formulated, the start and stop values will be updated from the list.

A slight change from 2.4.4 is that the dialog format for the list now requires the user to enter the square brackets. I think this is reasonable because it makes the list format consistent with how it is if you are editing on the schematic, although I accept it might confuse some users who were used to the old behavior.

@iwbnwif
Copy link
Contributor

iwbnwif commented Nov 24, 2024

@ra3xdh I would like to do some more refactoring on this class but it will depend on how practical it is to update the interface with the underlying components. For example, currently when a sweep 'list' is selected, the Start and Stop parameter names are replaced with Symbol and Points is replaced with Values.

I think it might be better if the components either ignored any unused parameters or did not rely on the valid parameters being at a certain position in the list. This only seems to apply to the sweep parameters, the other component parameters seem to be much more flexible.

@ra3xdh
Copy link
Owner

ra3xdh commented Nov 25, 2024

I would like to do some more refactoring on this class

Yes, renaming the properties is a bad design. But we must to keep the things as is. Introduction of new properties will break the schematic save/load. The schematic load relies on fields order, but not on fields name. The renaming to Symbol is a hack, because the property named Symbol doesn't go to the Qucsator netlist. The implementing of #974 will partially resolve this issue. I am intending to introduce some Simulation/NoSimulation flag. I am planning to start the implementation of #974 by the end of December or January.

@ra3xdh
Copy link
Owner

ra3xdh commented Nov 25, 2024

Fixed by #1093

@iwbnwif
Copy link
Contributor

iwbnwif commented Nov 25, 2024

I am intending to introduce some Simulation/NoSimulation flag. I am planning to start the implementation of #974 by the end of December or January

All understood, no problem. In the meantime I will keep squashing the bugs as they are identified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants