Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour with section headers #66

Open
2 tasks done
pedrommcarrasco opened this issue Nov 14, 2019 · 1 comment
Open
2 tasks done

Unexpected behaviour with section headers #66

pedrommcarrasco opened this issue Nov 14, 2019 · 1 comment

Comments

@pedrommcarrasco
Copy link

pedrommcarrasco commented Nov 14, 2019

Checklist

Hey @ra1028 👋
First of all, congrats on such a great project! I've been playing with Carbon lately and I think I managed to find a nasty issue with UITableView section headers or maybe I'm doing something wrong 🤔

Expected Behavior

Show all section headers and allow self-sizing

Current Behavior

  • First section header is not displayed
  • Self-sizing doesn't seem to work

Detailed Description (Include Screenshots)

  • Expected (with standard UITableView code)

Screenshot 2019-11-14 at 10 43 59

  • What I get with Carbon

Screenshot 2019-11-14 at 10 43 57

Sample Project:

Test.zip

Environment

  • Carbon version: What's currently in master

  • Swift version: 5.1

  • iOS version: 13.2

  • Xcode version: 11.2

  • Devices/Simulators: iPhone 11 Pro

  • CocoaPods/Carthage version: Not applicable (Swift Package Manager)

@pedrommcarrasco pedrommcarrasco changed the title Unexpected behaviour with self sizing section headers Unexpected behaviour with section headers Nov 14, 2019
@ra1028
Copy link
Owner

ra1028 commented Dec 9, 2019

Hi @pedrommcarrasco,
Thanks for your valuable reporting and sample project!

What I learned from your test app is that it works correctly when I set a value that is NOT UITableView.automaticDimension to estimatedSectionHeaderHeight.
This will probably happen if component don't have a referenceSize at here.
Fix it by returning a larger value if automaticSizing is set.

I'll fix this soon.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants