Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Iceborne DLC game ver. 10.12.00 please #24

Open
Holair opened this issue Jan 9, 2020 · 44 comments
Open

Update for Iceborne DLC game ver. 10.12.00 please #24

Holair opened this issue Jan 9, 2020 · 44 comments

Comments

@Holair
Copy link

Holair commented Jan 9, 2020

Hi! Overlay is not starting up with new Iceborne Ver. 10.12.00. Could you fix it please?
uholPXJ
@Holair Holair changed the title Update for Iceborne DLC please Update for Iceborne DLC game ver. 10.12.00 please Jan 9, 2020
@dannylin0711
Copy link

I think the memory pattern is defined in the Memory.json ,if you find the new memory pattern you can fill it into the Memory.json.

@Holair
Copy link
Author

Holair commented Jan 12, 2020

I think the memory pattern is defined in the Memory.json ,if you find the new memory pattern you can fill it into the Memory.json.

And how to find it?

@Elec0
Copy link

Elec0 commented Jan 14, 2020

I found PlayerDamagePattern at

matchAddress: 5394035031

I have not yet found anything else, even scanning over a very large amount of memory.

@trim21
Copy link

trim21 commented Jan 16, 2020 •
edited
Loading

@Holair use https://www.nexusmods.com/users/58674841 and cheat engine

@franzitrone franzitrone mentioned this issue Jan 17, 2020
Open
@NevanNedall
Copy link

NevanNedall commented Jan 19, 2020 •
edited
Loading

@Holair use https://www.nexusmods.com/users/58674841 and cheat engine

HelloWorld, frankly, is way more complicated to set up the way you want it than SmartHunter, and IMO, looks worse. I'd much rather see SmartHunter get updated, especially since all I care about is team damage and buffs UI.

While it admittedly has more features, with that comes added difficulty in configuring it, especially if someone's never seen a config file before.

@trim21
Copy link

trim21 commented Jan 19, 2020 •
edited
Loading

@NevanNedall agree with you, I prefer S martHunter.
I mean you can use helloworld and ce to find memory pattern and update smarthunter, it’s an answer of “ And how to find it?”

@X-Vaskys
Copy link

I mean you can use helloworld and ce to find memory pattern and update smarthunter

How to do so? Not sure how to use CE

@trim21
Copy link

trim21 commented Jan 20, 2020

@MS21GH I'm not a native English speaker, there should be some Engling articles about it.

@NevanNedall
Copy link

@trim21 Oh I see, my mistake

@X-Vaskys
Copy link

@trim21 What exactly should I look for?

@gabrielefilipp
Copy link

Hey guys i forked SmartHunter (https://github.com/gabrielefilipp/SmartHunter) and i'm trying to make it works again. So far PlayerDamage, MonsterData and an initial state of MonsterParts is working. If you find something interesting please le me know :)

@kai-oswald
Copy link

Hey @gabrielefilipp,
looks good on a first glance!
How did you go about finding the new memory patterns? Just with CE?

@gabrielefilipp
Copy link

Hey @kai-oswald,
yeah with CE and other DPS Meter open to calculate new offsets.

@NevanNedall
Copy link

@gabrielefilipp
Perhaps I'm just stupid.. but where do you get the actual EXE? I've always had trouble remembering how to properly download things off git

@X-Vaskys
Copy link

X-Vaskys commented Jan 22, 2020 via email

@NevanNedall
Copy link

The new branched version of it is also on Nexus?

@X-Vaskys
Copy link

X-Vaskys commented Jan 22, 2020 via email

@NevanNedall
Copy link

NevanNedall commented Jan 22, 2020 •
edited
Loading

I did that. There is no .exe present.
Edit: Well, I did find an exe in bin > x64 > Debug, but nothing happens when it's launched, but I suppose at that point I should bring it up on that project.

@gabrielefilipp
Copy link

gabrielefilipp commented Jan 22, 2020 •
edited
Loading

@NevanNedall here: https://github.com/gabrielefilipp/SmartHunter/blob/master/SmartHunter/bin/x64/Debug/SmartHunter.exe. Also remember that it's pretty buggy for a better meter use HelloWorld

@X-Vaskys
Copy link

X-Vaskys commented Jan 22, 2020 via email

@aklein13
Copy link

aklein13 commented Jan 22, 2020 •
edited
Loading

@NevanNedall When I lunch debug version it takes a while to load (5-10 sec?) and it's using more CPU then the game itself during the load. That is to be expected behaviour because it's a debug version not meant for normal use.
To get a good working exe can either compile it or use mine compiled version: https://drive.google.com/open?id=1nivyAgxPBPkRmFG6Bpy2Y_L9LeXVgv0a

Anyway I got it up and working: https://i.imgur.com/p6OZgqB.jpg

@Toukassay
Copy link

@NevanNedall When I lunch debug version it takes a while to load (5-10 sec?) and it's using more CPU then the game itself during the load. That is to be expected behaviour because it's a debug version not meant for normal use.
To get a good working exe can either compile it or use mine compiled version: https://drive.google.com/open?id=1nivyAgxPBPkRmFG6Bpy2Y_L9LeXVgv0a

Anyway I got it up and working: https://i.imgur.com/p6OZgqB.jpg

I don't know why I can launch your version but not the forked one from https://github.com/gabrielefilipp/SmartHunter
From this depot, it just don't launch. Nothing happen after clicking it. Yours worked like a charm. Strange.

@Toukassay
Copy link

I did that. There is no .exe present.
Edit: Well, I did find an exe in bin > x64 > Debug, but nothing happens when it's launched, but I suppose at that point I should bring it up on that project.

Well, same

@gabrielefilipp
Copy link

You need to have "Newtonsoft.Json.dll" file in the same folder with the .exe... If you don't have it just download the original version and then replace the new .exe

@scorpion21b
Copy link

player data widget isn't working

@gabrielefilipp
Copy link

@scorpion21b Player names and damages are correctly show. As for Player Buffs, yeah it's not working yet (like monster removable parts and monsters status effects)

@Halkcyon
Copy link

@gabrielefilipp Hey, in your fork - why don't you compile everything down to a single exe using .net core 3.1 or something? Would make distribution easier and there are a lot of perfomance gains seen there (WPF && WinForms work on Core 3.x+ now for Windows targets)

@gabrielefilipp
Copy link

@TheIncorrigible1 There's one compiled version under https://github.com/gabrielefilipp/SmartHunter/blob/master/SmartHunter/bin/x64/Debug/SmartHunter.exe

@Halkcyon
Copy link

@gabrielefilipp I have built it myself 🙂 I was just making a suggestion for improvement.

@masterrite
Copy link

@gabrielefilipp I got this when launching your forked version - any help here? Thanks:

JsonReaderException: Invalid property identifier character: �. Path 'Strings.LOC_MONSTER_GLAVENUS', line 18, position 0.
   at Newtonsoft.Json.JsonTextReader.ParseProperty()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateDictionary(IDictionary dictionary, JsonReader reader, JsonDictionaryContract contract, JsonProperty containerProperty, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)

@gabrielefilipp
Copy link

It says that there is an invalid character inside a file. Try to remove every json file inside the directory and restart SmartHunter.exe

@david50407
Copy link

david50407 commented Feb 1, 2020 •
edited
Loading

@gabrielefilipp I got permission denied while executing gabrielefilipp/SmartHunter

[2020-02-01 09:03:38] State Machine: CheckingForUpdates (2977 ms) > WaitingForProcess
[2020-02-01 09:03:38] Win32Exception: 存取被拒。
   於 System.Diagnostics.ProcessManager.OpenProcess(Int32 processId, Int32 access, Boolean throwIfExited)
   於 System.Diagnostics.Process.GetProcessHandle(Int32 access, Boolean throwIfExited)
   於 System.Diagnostics.Process.get_HasExited()
   於 SmartHunter.Core.MemoryUpdater.<>c__DisplayClass19_0.<CreateStateMachine>b__14()
   於 SmartHunter.Core.StateMachine`1.Update()
   於 SmartHunter.Core.MemoryUpdater.Update(Object sender, EventArgs e)

And would you open the issue tracker on your forked repo, or just reporting issues here?

--

UPDATE: "Open with administrator" works with this fork, but I don't want to run this application as admin (and the original application doesn't need either), can this be fixed?

@masterrite
Copy link

@gabrielefilipp I got permission denied while executing gabrielefilipp/SmartHunter

[2020-02-01 09:03:38] State Machine: CheckingForUpdates (2977 ms) > WaitingForProcess
[2020-02-01 09:03:38] Win32Exception: 存取被拒。
   於 System.Diagnostics.ProcessManager.OpenProcess(Int32 processId, Int32 access, Boolean throwIfExited)
   於 System.Diagnostics.Process.GetProcessHandle(Int32 access, Boolean throwIfExited)
   於 System.Diagnostics.Process.get_HasExited()
   於 SmartHunter.Core.MemoryUpdater.<>c__DisplayClass19_0.<CreateStateMachine>b__14()
   於 SmartHunter.Core.StateMachine`1.Update()
   於 SmartHunter.Core.MemoryUpdater.Update(Object sender, EventArgs e)

And would you open the issue tracker on your forked repo, or just reporting issues here?

right click and properties and set to run as admin

@david50407
Copy link

@masterrite thanks, but I don't want this application run as admin, the original (r00telement's) SmartHunter doesn't need admin permission either.

@gabrielefilipp
Copy link

Is your system 32 bit?

@david50407
Copy link

@gabrielefilipp 64bit Windows 10 18362.267

@gabrielefilipp
Copy link

@david50407 strange mine does not require an admin run

@trim21
Copy link

trim21 commented Feb 1, 2020 via email

@david50407
Copy link

@trim21 How do you start steam and mhw?
I closed steam and restart until it won't get auto-updated then start mhw from steam

@gabrielefilipp The wired thing is while mhw is not running, this permission denied exception still happened, that means process is not null, and there is a special Process instance (may created by Process[].FirstOrDefault?) which has higher permission causing permission denied

https://github.com/gabrielefilipp/SmartHunter/blob/master/SmartHunter/Core/MemoryUpdater.cs#L153

@david50407
Copy link

Maybe we can just skip the exception and try to match all processes in the Process array?
And print the "Start MHW or Run As Admin" message if none of them are matched?

@gabrielefilipp
Copy link

@david50407 I've pushed an update, can you try if that works?

@david50407
Copy link

@gabrielefilipp yes that works, thank you.

@dannylin0711
Copy link

The team widget is broken again

@gabrielefilipp
Copy link

The team widget is broken again

Yeah I know. Also rage status is broken. I’ve already fixed those but I’m currently experimenting with the buff widget so I’ll push when I’ve made it work again :)

@PizzaConsole PizzaConsole mentioned this issue Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests