Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inheritance for S4 objects #425

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Handle inheritance for S4 objects #425

merged 1 commit into from
Dec 4, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Nov 30, 2023

@mgirlich could you please take a look too?

See #400 (comment) for details.

@hadley hadley requested a review from DavisVaughan November 30, 2023 22:36
DavisVaughan
DavisVaughan approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I think this is the best way to do this without hurting performance in any way

@hadley hadley merged commit 43c9ad6 into main Dec 4, 2023
12 checks passed
@hadley hadley deleted the support-S4-inheritance branch December 4, 2023 13:58
@mgirlich
Copy link
Contributor

mgirlich commented Dec 8, 2023

Also looks like a good solution to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavisVaughan DavisVaughan DavisVaughan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadley @mgirlich @DavisVaughan