Avoid nested expect_error() in snapshot tests
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in env var (no effect) Use `expect_no_warning()` instead of using regexp = NA.
I think it was also to see the error call at a time where testthat would not show it. |
lionel-
reviewed
Oct 24, 2024
| @@ -116,7 +113,7 @@ test_that("vars_pull() produces correct backtraces", { | |||
| h <- function(base) if (base) stop("foo") else abort("foo") | |||
|
|
|||
| local_options( | |||
| rlang_trace_trop_env = current_env(), | |||
| @@ -79,22 +79,19 @@ | |||
| Error in `f()`: | |||
| ! `var` is absent but must be supplied. | |||
|
|
|||
| # vars_pull() has informative errors | |||
| # vars_pull() are base errors | |||
There was a problem hiding this comment.
I don't understand this new title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the goal was to have the class of the error.
This PR uses the
cnd_classargument fromexpect_snapshot()instead.I decided to use
to avoid having a large diff if it is decided the condition class is no longer important in certain tests.