Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry package downloads with a delay #71

Open
gaborcsardi opened this issue Dec 13, 2021 · 1 comment
Open

Retry package downloads with a delay #71

gaborcsardi opened this issue Dec 13, 2021 · 1 comment
Labels
feature a feature request or enhancement

Comments

@gaborcsardi
Copy link
Member

No description provided.

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Dec 13, 2021
@gaborcsardi
Copy link
Member Author

This is actually not as simple as it looks. We should probably not retry 404 and 401 and similar errors, because it is unlikely that those would work a minute later. Failing after an hour and 30 retries is much-much worse than failing after one try and one minute.

OTOH we could retry 5xx errors, maybe?

But we haven't seen issues with PPM for a while, so it is unclear if we still need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaborcsardi