fix(di): removed additional loop for iterating over providers

r-html · Mar 7, 2024 · add716a · add716a
1 parent 72aee4e
commit add716a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,10 +1,10 @@
 {
   "editor.formatOnSave": true,
   "[javascript]": {
-    "editor.formatOnSave": false
+    "editor.formatOnSave": true
   },
   "[typescript]": {
-    "editor.formatOnSave": false
+    "editor.formatOnSave": true
   },
   "eslint.autoFixOnSave": true,
   "eslint.validate": [
@@ -26,4 +26,4 @@
     "https://cdn.esm.sh": false,
     "https://deno.land": true
   } // also provides unstable type declarations in VS Code
-}
+}
diff --git a/packages/di/src/module/module.ts b/packages/di/src/module/module.ts
@@ -41,10 +41,11 @@ export const Module = <T>(
       }
 
       const providers = (entries.providers || []) as WithProviders[];
-      const factories = filterNonNull(providers).filter(v => !!v.useFactory);
 
-      for (const entry of factories) {
-        ProvidersMetadata.set(entry, entry);
+      for (const entry of providers) {
+        if (entry.useFactory) {
+          ProvidersMetadata.set(entry, entry);
+        }
       }
 
       for (const entry of filterNonNull(