Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qwik-nx compatible with qwik CLI integrations #135

Open
st-clair-clarke opened this issue Apr 22, 2023 · 8 comments
Open

Make qwik-nx compatible with qwik CLI integrations #135

st-clair-clarke opened this issue Apr 22, 2023 · 8 comments

Comments

@st-clair-clarke
Copy link

st-clair-clarke commented Apr 22, 2023

Is your feature request related to a problem? Please describe.
qwik-nx cannot ADD integrations/3rd-party packages to qwik as the native installer does.

Describe the solution you'd like
Currently, qwik offers the following integrations in the CLI:
┌ 🦋 Add Integration

◆ What integration would you like to add?
│ ● Adapter: Cloudflare Pages (Cloudflare Pages)
│ ○ Adapter: Azure Static Web Apps
│ ○ Adapter: Netlify Edge
│ ○ Adapter: Vercel Edge
│ ○ Adapter: Google Cloud Run server
│ ○ Adapter: Node.js Express Server
│ ○ Adapter: Node.js Fastify Server
│ ○ Adapter: Static site (.html files)
│ ○ Framework: React
│ ○ Integration: Auth.js (authentication)
│ ○ Integration: Playwright (E2E Test)
│ ○ Integration: PostCSS (styling)
│ ○ Integration: Styled-Vanilla-Extract (styling)
│ ○ Integration: Tailwind (styling)
│ ○ Integration: Vitest (Unit Test)
│ ○ Integration: Partytown (3rd-party scripts)

For me the priority would include the following in order of importance - top -> bottom

┌ 🦋 Add Integration

◆ What integration would you like to add?
│ ○ Framework: React
│ ○ Integration: Playwright (E2E Test)
│ ○ Integration: Auth.js (authentication)
│ ○ Integration: Styled-Vanilla-Extract (styling)
│ ○ Integration: Vitest (Unit Test)
│ ○ Integration: PostCSS (styling)
│ ○ Integration: Partytown (3rd-party scripts)

@dmitry-stepanenko
Copy link
Contributor

@st-clair-clarke some of these features are already available

  • ○ Integration: Playwright (E2E Test) - e2e-project generator with "playwright" option
  • ○ Integration: Vitest (Unit Test) - right now is being configured for each app/lib when you create it, I'll make it available separately for those rare cases when projects are generated with --unitTestRunner=none
  • ○ Integration: PostCSS (styling) - right now it only comes as part of tailwind configuration, I'll also make it available separately

Also, please expect React integration in the next release, I'm working on it now. Will also consider working on other things you have requested sooner.

@st-clair-clarke
Copy link
Author

Cheers. Thanks. Looking forward to React. Because qwik is in its early stages, it has no commendable UI library, but react-based library can be use if it is integrated.

@dmitry-stepanenko
Copy link
Contributor

@st-clair-clarke react is available in 0.15.6

@st-clair-clarke
Copy link
Author

Well appreciated! Thank you!

@faileon
Copy link
Contributor

faileon commented Jun 15, 2023

How about deployment integrations (deno or vercel adapters)? Any plans for those?

@dmitry-stepanenko
Copy link
Contributor

@faileon we will definitely have netlify and express in the nearest future, deno or vercel won't be around for a time being.

If you need support integrating those in your nx monorepo, I can help in the discord

@PeteJStewart
Copy link

I also need some integrations that are not possible.
I'm after the Builder.io integration and the Authjs integration.
Ideally, a way to add any integration.

Can I help add these integrations?

@dmitry-stepanenko
Copy link
Contributor

Hey @PeteJStewart , of course, that would be awesome! There're a few integrations to follow as an example, also feel free to DM me on discord in case there're any issues that you face

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants