Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create autodiff doc for mcsolve #65

Merged
merged 7 commits into from
Aug 29, 2024
Merged

create autodiff doc for mcsolve #65

merged 7 commits into from
Aug 29, 2024

Conversation

rochisha0
Copy link
Contributor

show the gradient calculation for mcsolve

@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10607968139

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 90.303%

Files with Coverage Reduction New Missed Lines %
src/qutip_jax/measurements.py 1 98.92%
src/qutip_jax/settings.py 5 70.59%
Totals Coverage Status
Change from base Build 9842191187: -0.2%
Covered Lines: 1220
Relevant Lines: 1351

💛 - Coveralls

@rochisha0 rochisha0 marked this pull request as ready for review August 20, 2024 08:47
@Ericgig
Copy link
Member

Ericgig commented Aug 20, 2024

I merged the changes from dev.major into master could you check that everything works and remove the note about it.

@rochisha0
Copy link
Contributor Author

@Ericgig I've tested this and it is working.

Comment on lines 59 to 60
import qutip as qt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use qt and qjax in example.

Comment on lines 50 to 54

The automatic differentiation (`jax.grad`) in `mcsolve` does not support parallel map operations.
To ensure accurate gradient computations, please use the default serial execution instead of
parallel mapping within `mcsolve`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the only explanation of the example, let's not put it in a note.

Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough.
The explanation feels a little dry but it shows how it works.

@Ericgig Ericgig merged commit b7ff6de into qutip:master Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants