-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create autodiff doc for mcsolve #65
Conversation
Pull Request Test Coverage Report for Build 10607968139Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I merged the changes from |
@Ericgig I've tested this and it is working. |
doc/source/autodiff.rst
Outdated
import qutip as qt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use qt
and qjax
in example.
doc/source/autodiff.rst
Outdated
|
||
The automatic differentiation (`jax.grad`) in `mcsolve` does not support parallel map operations. | ||
To ensure accurate gradient computations, please use the default serial execution instead of | ||
parallel mapping within `mcsolve`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the only explanation of the example, let's not put it in a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough.
The explanation feels a little dry but it shows how it works.
show the gradient calculation for
mcsolve