Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weekly tests #24

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Add weekly tests #24

merged 9 commits into from
Jan 11, 2024

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Jul 24, 2023

Runs tests automatically each week.
Any failure should trigger an email to those watching this repo.

@Ericgig Ericgig force-pushed the auto_tests branch 10 times, most recently from b308bf5 to 845161f Compare July 24, 2023 19:08
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@Ericgig
Copy link
Member Author

Ericgig commented Oct 20, 2023

@AGaliciaMartinez @quantshah,
Could you review this.
For security reason, new workflow don't have access to secret during PR so it needs to be merged to test the sending email step.

If it work as intended, each week tests would run and send and email to the google group on failure.
We can trigger the tests manually and send email to a desired destination. This is mostly to allow me to debug potential issues with the email server without spamming the google group.

Copy link
Member

@AGaliciaMartinez AGaliciaMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the merge @Ericgig. Seems good to me, lets merge it and test if ti works. Perhaps I have one question about this PR. Will the emails be sent by default to anyone in qutip-admin? if so, I would suggest to somehow restrict this as it could be too much spam for some that are not directly involved in writing code.

@Ericgig
Copy link
Member Author

Ericgig commented Dec 18, 2023

Thank you for reviewing. I will wait until January to merge.

Yes this will send email to the qutip-admin email list when failing.
We should not use hard coded personal email here.
Ideally a qutip-dev email would be better.

@Ericgig Ericgig merged commit 99b53be into qutip:master Jan 11, 2024
3 checks passed
@Ericgig Ericgig deleted the auto_tests branch January 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants