Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room description window constantly oscillates between one line and two lines. #916

Open
dreirund opened this issue Nov 11, 2024 · 8 comments
Assignees
Labels
bug/fix Quaternion doesn't work as expected

Comments

@dreirund
Copy link

dreirund commented Nov 11, 2024

I just compiled Quaternion from this git repository using this modified recipe, and I opened a room that has a description and the description window constantly oscillates between two lines, one line window height and scrollbars and one line, two lines window height and no scrollbars.

I attach a video recording this (the overlayed windows are there to censor sensitive information).

description_oscillating.webm
@KitsuneRal KitsuneRal added the bug/fix Quaternion doesn't work as expected label Nov 11, 2024
@KitsuneRal
Copy link
Member

There's an inherent problem with text layout if scrollbars are allowed to disappear when they are not needed; but showing them at all times is not the best option in this case either. I could say it's a problem in QML but I think I don't make it easier with my dynamic height adjustments. I'll see if it can be helped.

@KitsuneRal KitsuneRal self-assigned this Nov 11, 2024
@KitsuneRal
Copy link
Member

Btw, I took a look at the recipe, and I have a couple of comments on it:

  • It's more accurate to build the version 0.0.97~beta.git* if that's allowed by your distribution rules; although, admittedly, the difference from 0.0.96.1 is so far minimal
  • -DBUILD_WITH_QT6 is no more supported because it's always Qt 6 now; you can safely drop it
  • -DBUILD_TESTING=OFF works on libQuotient but not on Quaternion; as I understand it, you build Quaternion with an out-of-tree libQuotient (which is usually recommended for distro packages), and that case, this option has no effect

KitsuneRal added a commit that referenced this issue Nov 11, 2024
Recalculation of padding depending on whether the scroll bar is there
can easily break the already fragile layout logic, bringing minimal
benefits in return (it was made to avoid the text ending up under
transient scrollbars that are overlapping with the client area - but
transient scrollbars disappear after scrolling anyway).

Hopefully fixes #916.
@KitsuneRal
Copy link
Member

Can you check if this branch fixes the problem?

@KitsuneRal KitsuneRal moved this to In work in Quaternion 1 Nov 11, 2024
@dreirund
Copy link
Author

dreirund commented Nov 11, 2024 via email

@KitsuneRal
Copy link
Member

Yes, this is the correct commit. Then I'm afraid I have to ask you to change the window or left dock pane size a bit, as a workaround. This may also be a problem with a specific Qt theme, or, as I said, an inherent glitch of the code in Qt that lays out text in a text area. I might try to take it to Qt issue tracker but that's almost never a fast track.

@KitsuneRal
Copy link
Member

@dreirund you may try to check the same branch again (commit 62ae4e4), I'm now sizing the text area closer to Qt's own practices.

@dreirund
Copy link
Author

@dreirund you may try to check the same branch again (commit 62ae4e4)

Seems to work now (for the room where I had this issue).

I don't see any scrollbars now, and the area stays constant size (one line in this case).

@dreirund
Copy link
Author

Off-Topic: Any way how I can verify the quaternion session?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/fix Quaternion doesn't work as expected
Projects
Status: In work
Development

No branches or pull requests

2 participants