-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room description window constantly oscillates between one line and two lines. #916
Comments
There's an inherent problem with text layout if scrollbars are allowed to disappear when they are not needed; but showing them at all times is not the best option in this case either. I could say it's a problem in QML but I think I don't make it easier with my dynamic height adjustments. I'll see if it can be helped. |
Btw, I took a look at the recipe, and I have a couple of comments on it:
|
Recalculation of padding depending on whether the scroll bar is there can easily break the already fragile layout logic, bringing minimal benefits in return (it was made to avoid the text ending up under transient scrollbars that are overlapping with the client area - but transient scrollbars disappear after scrolling anyway). Hopefully fixes #916.
Can you check if this branch fixes the problem? |
Can you check if [this branch](https://github.com/quotient-im/Quaternion/tree/kitsune/fix-room-header-layout-havoc) fixes the problem?
No, it still oscillates.
(To double check for you if I used the correct source: `git log` after checkout shows as last message
…-- %< --
commit bead28b (HEAD -> makepkg, origin/kitsune/fix-room-header-layout-havoc)
Author: Kitsune Ral <censored>
Date: Mon Nov 11 20:32:12 2024 +0100
Timeline: Don't mess with room header padding
Recalculation of padding depending on whether the scroll bar is there
can easily break the already fragile layout logic, bringing minimal
benefits in return (it was made to avoid the text ending up under
transient scrollbars that are overlapping with the client area - but
transient scrollbars disappear after scrolling anyway).
Hopefully fixes #916.
-- >% --
)
|
Yes, this is the correct commit. Then I'm afraid I have to ask you to change the window or left dock pane size a bit, as a workaround. This may also be a problem with a specific Qt theme, or, as I said, an inherent glitch of the code in Qt that lays out text in a text area. I might try to take it to Qt issue tracker but that's almost never a fast track. |
Off-Topic: Any way how I can verify the quaternion session? |
I just compiled Quaternion from this git repository using this modified recipe, and I opened a room that has a description and the description window constantly oscillates between two lines, one line window height and scrollbars and one line, two lines window height and no scrollbars.
I attach a video recording this (the overlayed windows are there to censor sensitive information).
description_oscillating.webm
The text was updated successfully, but these errors were encountered: