[WIP] require CMake 3.20+ #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
There's some bug that doesn't let the tests compile on GPUs |
|
It looks like the issue is that It's not immediately obvious to me how to fix it. I will ask the AMReX developers if they have a fix. |
|
/azp run |
|
/azp run |
1 similar comment
|
/azp run |
|
/azp run |
|
Since this doesn't work, I'm closing it for now. Hopefully CMake will work in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces a minimum version requirement of CMake 3.20.
This allows us to remove some workarounds that were only needed in older CMake versions. CMake 3.20 was released in 2021, so it should be widely available for all users.
This causes a build error on GPU due to a change in how CMake treats
CMAKE_CUDA_ARCHITECTURESthat we currently don't have a fix for.