Add tests and fix for instance_id error (ExpiredTime not set) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayodesegun
changed the title
|
Some unintended commits are appearing here...need to solve that :(. |
|
I am just wondering who you are and why are you still working on this project? @bayodesegun |
|
@qitia Sorry, I don't understand your queries. What do you want to know and why? |
|
I once worked in Quixey and I think this repo is not maintained by anyone
now. Why are you still working on this project?
…On Thu, Apr 12, 2018 at 1:46 AM, Bayode Aderinola ***@***.***> wrote:
@qitia <https://github.com/qitia> Sorry, I don't understand your queries.
What do you want to know and why?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFfJ7jXA1-kaRtsSLmTfMuP3rG_zxd7hks5tnkGLgaJpZM4S9mhv>
.
|
|
@qitia Well, I'm working on it because I'm currently using it. |
|
I'll see if we can get clearer docs that this is no longer maintained since Quixey folded. @bayodesegun looks like you'll need to live with your fork of it :( If you get to a minor version rev, we can probably remove this version from PyPI and you can take it over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All. This commit fixes #37 .
Issue #37 was happening because
ExpiredTimeis sometimes not set (so an empty string, which is not aDate)on some instances (such as PAYG instances for example).A test was also added to ecs.connection test.