Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a vagrant config for testing #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add a vagrant config for testing #15

wants to merge 1 commit into from

Conversation

bruno-fs
Copy link
Contributor

I used these images to play around with the installer. Might be useful for more people.

@abellotti
Copy link
Contributor

abellotti commented Jul 16, 2024

I think that's fine 👍 do you need it installed with the RPM (mentioned in the spec file) or just running from source/git ?

@bruno-fs
Copy link
Contributor Author

only needed when running from source. I think adding it to the RPM would be too much

Copy link
Member

@infinitewarp infinitewarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a README or DEVELOPMENT doc or at least some inline comments somewhere to explain to future readers why this Vagrantfile exists and how to use it. Otherwise, it seems really strange and unexpected to be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants