Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run specs for random scenarios #145

Open
michieldenhaan opened this issue Oct 7, 2020 · 2 comments
Open

Run specs for random scenarios #145

michieldenhaan opened this issue Oct 7, 2020 · 2 comments

Comments

@michieldenhaan
Copy link
Contributor

michieldenhaan commented Oct 7, 2020

The ETM has various 'laws' that should hold under any circumstances. E.g. supply and demand of the hydrogen, collective heat and ccus mekkos should always balance, inputs and outputs of (most) nodes should be equal etc.

I think it would be very useful if we have something like Turk::Scenario.new(random, n=10) that generates n random scenarios. With random I mean:

  • Random area
  • Random target year
  • Random amount of inputs set
  • Random values for those inputs

to make testing for these 'laws' more robust. Currently, we have to explicitly specify all of the above. As a result we typically only test a few very specific situations.

Curious to hear your thoughts, @ChaelKruip, @antw

@antw
Copy link
Contributor

antw commented Oct 19, 2020

The random element makes me a little uneasy, since it's quite possible that the scenario might set inputs which have nothing to do with the law being tested. It's possible that one of these laws might be broken, but for us to miss it because the wrong random numbers are generated. It might be that a law is only broken when a certain combination of inputs are set, and with 811 inputs the probability of happening upon that combination is quite low.

However I don't have a better suggestion, so I've added this to the backlog.

@michieldenhaan
Copy link
Contributor Author

Thanks! I fully agree with your concerns. My worry is that we currently only test one or two predefined settings for most 'laws'. Supplementing this with X random combinations that change every night may allow us to find flaws that would otherwise have gone unnoticed. But it is definitely not fool proof.

@antw antw removed their assignment Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants