Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write rake task to remove outdated attributes from node files #3097

Open
mabijkerk opened this issue Jul 31, 2024 · 2 comments
Open

Write rake task to remove outdated attributes from node files #3097

mabijkerk opened this issue Jul 31, 2024 · 2 comments
Assignees
Labels
Pinned Will never be marked as stale or auto-closed.

Comments

@mabijkerk
Copy link
Member

mabijkerk commented Jul 31, 2024

There are a number of attributes that are outdated. See quintel/documentation#158, but to also give examples here:

  • hours_maint_nl
  • hours_place_nl
  • hours_prep_nl
  • ...

Currently, we simply delete them whenever we encounter them. It would be more efficient however to build a rake task and remove them in one go from all node files, whenever we retire an attribute. Note: we would then preferably retire the attributes completely. Not only from node files, but also the relevant queries and the attribute itself on Atlas.

Copy link

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Sep 30, 2024
@kndehaan kndehaan added Pinned Will never be marked as stale or auto-closed. and removed Stale Issue had no activity for 60 days and will be, or has been, closed. labels Sep 30, 2024
@mabijkerk
Copy link
Member Author

Note: this should not be a separate Python script. It should be a formalized rake task in Ruby, that uses the functionalities from Atlas. See for example how import_node.rb uses the Atlas::EnergyNode functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants