Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor front-end issues with coupled must-run interconnectors #4345

Open
louispt1 opened this issue Oct 1, 2024 · 2 comments
Open

Fix minor front-end issues with coupled must-run interconnectors #4345

louispt1 opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
Pinned Will never be marked as stale or auto-closed.

Comments

@louispt1
Copy link
Contributor

louispt1 commented Oct 1, 2024

Separate to #4341, because the interconnector coupling simply de-activates some sliders and replaces the upload module with the new coupling curves, we decided it's not clear enough that a coupling is in effect.

So this issue is to update the curves upload (when coupled) so that it also has the little coupling icon.

Screenshot 2024-10-01 at 11 50 50

The icon would go on this part:
image

@louispt1 louispt1 self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Dec 1, 2024
@mabijkerk mabijkerk added Pinned Will never be marked as stale or auto-closed. and removed Stale Issue had no activity for 60 days and will be, or has been, closed. labels Dec 2, 2024
@kaskranenburgQ kaskranenburgQ changed the title Clarify coupling in UX for Interconnectors Must-run inteconnectors front-end issues Dec 3, 2024
@kaskranenburgQ
Copy link
Contributor

kaskranenburgQ commented Dec 3, 2024

Some other issues concerning the external coupling of interconnectors we found are:

  • Uploading a must-run curve returns the error message "An error occured". A refresh of the page indicates that the curve is actually loaded in properly, so the error message is false.
    Screenshot 2024-12-03 at 09 17 03
  • When the external coupling input external_model_interconnectors is set to 1.0, all the slide texts for the curves will be set to "Coupled custom curves". Even when the interconnector is not coupled, as seen here:
    Screenshot 2024-12-02 at 15 14 28

@mabijkerk mabijkerk changed the title Must-run inteconnectors front-end issues Fix minor front-end issues with coupled must-run interconnectors Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants