Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the PV parsers #102

Open
1 of 2 tasks
redekok opened this issue Apr 13, 2023 · 0 comments
Open
1 of 2 tasks

Clean up the PV parsers #102

redekok opened this issue Apr 13, 2023 · 0 comments
Assignees
Labels

Comments

@redekok
Copy link

redekok commented Apr 13, 2023

As a result of this issue I took a look at the modelling of our PV parsers. Currently, the app's VolatileParser handles PVPark and PVInstallation assets in the same way. Also, the RooftopPVParser doesn't seem to filter on ROOFTOP_PV as type of installation. Further, we've now implemented a quick and dirty fix for the situation in which no (SingleValue) profile has been specified, which should be replaced by a neater solution. Hence, I propose the following changes:

  • Replace the configs for PVPark and PVInstallation by a generic PVPanel one. Since PVPanel is the parent of both PVPark and PVInstallation, this should work I think.
  • Refactor the modelling of the RooftopPV parser: (1) filter for PVInstallationTypeEnum= ROOFTOP_PV and (2) provide a warning if no SolarPotential nor a production (in the form of a SingleValue profile) is given in the ESDL file.

Notifying @Charlottevm

@redekok redekok added the mmvib label Apr 13, 2023
@redekok redekok self-assigned this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant