Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split setting parameters from the inputs endpoint into a separate endpoint. #1445

Open
robcalon opened this issue Jul 2, 2024 · 2 comments
Assignees
Labels
Pinned Will never be marked as stale or auto-closed.

Comments

@robcalon
Copy link

robcalon commented Jul 2, 2024

The https://engine.energytransitionmodel.com/api/v3/scenarios/xxxx/inputs endpoint contains mostly float-like parameter values with the occasional boolean or enum typed parameters. Processing mixed types from the endpoint is becoming increasingly painful in exporting results as most Python libraries don't like mixed types.

Would it be an option to split off the boolean and enum type parameters to a different endpoint, e.g. https://engine.energytransitionmodel.com/api/v3/scenarios/xxxx/settings to make it more easily to process the settings endpoint? I would also propose to migrate the boolean parameters that are now implemented as float-like parameters with 0, 1 to proper boolean parameters with an allowed setting of true/false to prevent setting a float value instead.

This would provide the additional benefit that inter- or extrapolation of parameters becomes more trivial as only float-like parameters can be inter- or extrapolated, you'd like to keep all 'settings' parameters the same.

@robcalon
Copy link
Author

robcalon commented Jul 2, 2024

@noracato could you have a look at this one?

@robcalon robcalon changed the title Split setting parameters from the parameters endpoint. Split setting parameters from the inputs endpoint into a separate endpoint. Jul 2, 2024
@noracato noracato self-assigned this Jul 5, 2024
Copy link

github-actions bot commented Sep 4, 2024

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Sep 4, 2024
@mabijkerk mabijkerk added Pinned Will never be marked as stale or auto-closed. and removed Stale Issue had no activity for 60 days and will be, or has been, closed. labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants