-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @ExpectNoInflaterMemoryLeak #98
Comments
Tomcat has a lot of memory leak protections since version 7: https://cwiki.apache.org/confluence/display/TOMCAT/MemoryLeakProtection Maybe we can create multiple memory leak detection based on those examples. This could be a very cool addition to what quickperf already does! |
Btw. There is also Leak Canary from Square for detecting memory leaks. It's originally developed for Android apps, but there is some support for applying it for JVM apps: https://square.github.io/leakcanary/recipes/#detecting-leaks-in-jvm-applications . Perhaps some parts could be reused in QuickPerf? |
I ignored that Leak Canary could work with a JVM app. It would be interesting to reuse the Leak Canary HeapAnalyzer in QuickPerf. |
Information coming from interesting Twitter conversations about Leak Canary: |
JFR may reveal some heap memory leaks with the help of the Old Object Sample event: http://hirt.se/blog/?p=1055 QuickPerf can trigger JFR profiling and retrieve JFR events. However, the Old Object Sample event was introduced in JDK 10. So, the heap leak detection would only work from this JDK version. |
java.util.zip.Inflater
can cause non-heap memory leaks, as explained in this presentation. They can be detected during the application execution thanks to the Leakchecker project. This issue aims to provide an@ExpectNoInflaterMemoryLeak
annotation in QuickPerf to detect this memory leak as soon as possible. The@ExpectNoInflaterMemoryLeak
will be based on the Leakchecker project. This project has anApache 2.0 license
so that it is ok to detect inflater memory leak in the same way in QuickPerf project. Both in QuickPerf source code and QuickPerf documentation, we will take care of mentioning the Leakchecker project.This issue is focussed on memory leaks that could come from
Inflater
. Later, we could detect other kinds of potential memory leaks, such as those that could be raised fromObjectInputStream
.The text was updated successfully, but these errors were encountered: