-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need Post-Test Step for Converting Logs #131
Comments
It looks like it's not possible to trap signals when using the |
With @larseggert's help we've been able to push an updated MsQuic Docker image that supports streaming, but it still has issues. There seems to be a race condition where the server is shutdown before all the logs flush to disk. Perhaps, as a temporary stop-gap solution you add a sleep for a second or two before killing the server? |
That would be a workaround, but not an easy one. —abort-on-container-exit doesn’t allow you to do anything like that, so we’d have to start and stop the containers manually. I really hope that someone will pick up my docker-compose issue, otherwise we’ll have no choice but to actually implement that workaround. |
Nobody picked up the issue in more than a week. Time to implement the workaround! 👎 |
After playing around with this for a while, it seems like the problem is the following: We need to run a According to the documentation it's only possible to pass a physical file to the @jlaine, can we ask for your wisdom here? I'm sure there must be better way in Python to do this... |
We have some streaming stuff enabled, but it doesn't work very well because it seems to be timer based, so much of the time we end up losing much of the end of our logs (where the relevant errors end up being). I'd really be appreciated if we could get this feature in! |
Any updates? I'd really like to get consistent logging for msquic working, but can't do it without this. |
Is it possible to make progress on this issue? Or is it blocked completely on the docker-compose issue/Python |
There's code for that in this branch: https://github.com/marten-seemann/quic-interop-runner/tree/separate-docker-compose-runs |
Right now, MsQuic cannot collect logs because it requires commands to be executed after the test runs. But the current setup runs the server continuously and then just kills the container. This never allows for us to collect/convert our log files. We need either:
The text was updated successfully, but these errors were encountered: